dao: split out component into subcrate. #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unlocks splitting out the `stake` (which currently depends on the dao component, to handle funding stream rewards to the dao) and then `governance` (which depends on the `stake` component as well). While the DAO isn't a "full component" at present, in the sense that we don't have begin/end block hooks for it, it does have chain state and associated transaction actions, and we might want it to have queries, events, RPCs, etc.
hdevalence
force-pushed
the
split-app-dao
branch
from
2e67efc to
c6e17d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2288.
This unlocks splitting out the
stake(which currently depends on the dao component, to handle funding stream rewards to the dao) and thengovernance(which depends on thestakecomponent as well).While the DAO isn't a "full component" at present, in the sense that we don't have begin/end block hooks for it, it does have chain state and associated transaction actions, and we might want it to have queries, events, RPCs, etc.