Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex: add epoch height to BatchSwapOutputData #2448

Merged
merged 2 commits into from
May 2, 2023
Merged

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented May 2, 2023

Closes #2351

Note also that I don't think we need the epoch_duration on the SwapClaim SwapClaimPlan, but I don't want to make a breaking change to the protos.

@redshiftzero redshiftzero temporarily deployed to smoke-test May 2, 2023 18:25 — with GitHub Actions Inactive
@redshiftzero redshiftzero marked this pull request as ready for review May 2, 2023 20:27
@redshiftzero redshiftzero changed the title wip: add epoch height to BatchSwapOutputData dex: add epoch height to BatchSwapOutputData May 2, 2023
@redshiftzero redshiftzero requested review from hdevalence and zbuc May 2, 2023 20:28
@zbuc
Copy link
Member

zbuc commented May 2, 2023

The epoch_duration on SwapClaim is definitely not needed any more after this

@redshiftzero redshiftzero merged commit 78f5972 into main May 2, 2023
@redshiftzero redshiftzero deleted the bsod-update branch May 2, 2023 21:44
@cratelyn cratelyn added the A-dex Area: Relates to the dex label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include epoch and intra-epoch block height in BatchSwapOutputData
3 participants