Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AddressByIndex handler for cases of AddressIndexes with empty randomizers #2497

Merged
merged 1 commit into from
May 6, 2023
Merged

Fix AddressByIndex handler for cases of AddressIndexes with empty randomizers #2497

merged 1 commit into from
May 6, 2023

Conversation

aubrika
Copy link
Contributor

@aubrika aubrika commented May 5, 2023

Closes #2490

@aubrika aubrika temporarily deployed to smoke-test May 5, 2023 20:59 — with GitHub Actions Inactive
@hdevalence
Copy link
Member

I tested this locally using Buf studio and confirmed that it worked. I also discovered that removing HTTP/1 support, which broke the web extension for any non-https endpoints, broke our CORS headers, making it impossible to query a local view service.

@hdevalence hdevalence merged commit 44bc42b into main May 6, 2023
@hdevalence hdevalence deleted the 2490-address-by-index-fix branch May 6, 2023 04:41
@hdevalence hdevalence mentioned this pull request May 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust view server should allow default randomizers in AddressByIndex
2 participants
@aubrika @hdevalence