Refactor Denom to DenomMetadata for compatibility with Cosmos SDK #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubrika
force-pushed
the
2310-denom-rename
branch
from
6c1d58b to
06e9216
Compare
aubrika
force-pushed
the
2310-denom-rename
branch
4 times, most recently
from
a056691 to
8ee9e16
Compare
aubrika
force-pushed
the
2310-denom-rename
branch
from
8ee9e16 to
0d8ba48
Compare
aubrika
force-pushed
the
2310-denom-rename
branch
from
0d8ba48 to
951f815
Compare
aubrika
force-pushed
the
2310-denom-rename
branch
from
951f815 to
50543f9
Compare
aubrika
force-pushed
the
2310-denom-rename
branch
from
50543f9 to
0816a2e
Compare
aubrika
force-pushed
the
2310-denom-rename
branch
from
0816a2e to
9c3cb80
Compare
aubrika
force-pushed
the
2310-denom-rename
branch
from
9c3cb80 to
cb4827a
Compare
hdevalence
reviewed
May 16, 2023
Comment on lines
23
to
27
| #[serde(try_from = "pb::Asset", into = "pb::Asset")] | ||
| pub struct Asset { | ||
| pub id: Id, | ||
| pub denom: Denom, | ||
| pub denom: DenomMetadata, | ||
| } |
There was a problem hiding this comment.
What's the point of the Asset proto message, now that we have DenomMetadata ?
There was a problem hiding this comment.
Hmm, yes, seems redundant. Should I add removing Asset and replacing with DenomMetadata to this refactor?
There was a problem hiding this comment.
I don't know. This PR is already terrifyingly large, maybe we should try to land it and then do the Asset removal in another step?
There was a problem hiding this comment.
I was hoping you would suggest that :) sounds great
hdevalence
reviewed
May 16, 2023
hdevalence
reviewed
May 16, 2023
hdevalence
reviewed
May 16, 2023
aubrika
force-pushed
the
2310-denom-rename
branch
from
cb4827a to
7e25939
Compare
|
This looks like a move in the right direction -- there are probably further things we'll want to do, but we should merge this now to avoid generating conflicts (cc @plaidfinch ) |
conorsch
added a commit
to penumbra-zone/osiris
that referenced
this pull request
May 18, 2023
Matches changes in penumbra-zone/penumbra#2520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2310