Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentangle compact block from shielded pool and dex #2529

Merged
merged 8 commits into from
May 14, 2023
Merged

Conversation

plaidfinch
Copy link
Collaborator

Resolves #2440.

@plaidfinch plaidfinch self-assigned this May 10, 2023
@plaidfinch plaidfinch marked this pull request as ready for review May 10, 2023 21:11
@plaidfinch plaidfinch temporarily deployed to smoke-test May 11, 2023 07:40 — with GitHub Actions Inactive
@plaidfinch plaidfinch temporarily deployed to smoke-test May 12, 2023 20:42 — with GitHub Actions Inactive
@plaidfinch
Copy link
Collaborator Author

plaidfinch commented May 14, 2023

I'm getting a smoke test failure here relating to the new swap exercise functionality. Not sure how to debug — perhaps @zbuc could you take a look at this on Monday?

Edit: now the smoke test has passed, so I'm going to optimistically merge this.

@plaidfinch plaidfinch temporarily deployed to smoke-test May 14, 2023 18:18 — with GitHub Actions Inactive
@plaidfinch plaidfinch merged commit 9550222 into main May 14, 2023
@plaidfinch plaidfinch deleted the sct-disentangle branch May 14, 2023 18:38
@cratelyn cratelyn added the A-dex Area: Relates to the dex label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disentangle SCT and CompactBlock responsibilities
3 participants