crypto: fixes to TradingPair allocation and division of Amounts #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
force-pushed
the
zk-trading-pair-order
branch
from
059367f to
3ad3231
Compare
redshiftzero
changed the title
redshiftzero
commented
May 12, 2023
redshiftzero
force-pushed
the
zk-trading-pair-order
branch
from
3ad3231 to
77521fd
Compare
redshiftzero
force-pushed
the
zk-trading-pair-order
branch
from
77521fd to
cfc4332
Compare
The remainder cannot be equal to the divisor, it must be strictly less.
These tests will cause a CI failure if an unintentional circuit breaking change is made.
redshiftzero
force-pushed
the
zk-trading-pair-order
branch
from
cfc4332 to
e1cd4df
Compare
redshiftzero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2350
This PR:
TradingPairVar(represents aTradingPairin R1CS), to note that we are intentionally not checking that the asset IDs are ordered as expected in the canonical representation of the out of circuitTradingPair. This is because we are only using theTradingPair's two asset IDs in the swap commitment integrity check, which will fail if the asset IDs are switched.AmountVars, where we now ensure that the remainder cannot equal the divisor, and that the divisor is non-zero.