fix: temporarily limit dex values to 60 bits #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we leave the existing check as-is, and have a dedicated code path for the temporary restrictions? Then when it's time to remove, we can just delete the temporary check in isolation — in the course of fixing the underlying issue we might determine, for instance, that we needed some restriction on the bitsize, and it'd be cleaner if we could write it separately from the checks we intend to remove. |
hdevalence
reviewed
May 14, 2023
hdevalence
reviewed
May 14, 2023
erwanor
commented
May 14, 2023
| @@ -2,18 +2,23 @@ | |||
|
|
|||
| set -euo pipefail | |||
|
|
|||
| PREVIOUS_TESTNET_DIRECTORY=$(find . -mindepth 1 -type d | tail -n1) | |||
| echo "#####################################################" | |||
| PREVIOUS_TESTNET_DIRECTORY=$(find . -mindepth 1 -type d | sort | tail -n1) | |||
There was a problem hiding this comment.
The change is here, I've added a sort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2560, the diff is large because we're regenerating testnet allocations but each individual commit should consist of a relevant subtask.