Stub distributions module and pull out penumbra_stake crate
#2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaidfinch
changed the title
penumbra_stake crate
|
Looks like this is failing to be wasm-compatible, probably because I didn't set up the optional dependencies correctly. Will fix shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a stub
penumbra_distributionscrate and integrates it as a component into the app, without defining any functionality for it yet. Additionally, it pulls outpenumbra_stakeas a crate, which means thatpenumbra_distributionswill be able to depend on it in the future.In the course of the stake refactor, I fixed a long-outstanding FIXME saying that validator definitions should not be raw protos in parsed actions: this was in fact a necessary change because I needed to implement the trait
ActionHandlerforValidatorDefinition, something not possible in a crate other than the one in which it or the trait was defined.Although this does not yet implement any distributions functionality, we should merge it ASAP, so that it does not generate more conflicts.