storage: index keys by keyhash #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `tendermint-rs` supports Tendermint `0.34.x` alongside `0.37.x`, we have to make sure that we refer to the ABCI messages defined in the versioned crates as opposed to importing the re-exports from the root crates which by convention, point to the domain types for the latest Tendermint version. As of `0.37.x`, this is not a problem but it could cause confusing breakage in the future.
Co-authored-by: finch <finch@plaidfinch.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1647 and includes a drive-by fix for using the versioned
v0_34abci message domain types