build: revert to proto-compiler #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overhaul of the protobuf codegen logic from #2619 was incomplete: we encountered problems with serde implementations. Wasn't able to sort them quickly, and we're about to release Testnet 53, so I'm backing out the recent changes to unblock in-flight PRs. Will return to disentangling the protobuf story on subsequent sprint. Revert "fix: re-enable grpc server reflection" This reverts commit f8d09f6. Revert "ci: update buf target dir" This reverts commit 3e7b4c7. Revert "dev: add buf breaking change detection" This reverts commit 724ccf6. Revert "ci: eliminate the chore of buf mod update" This reverts commit 1f28bb2. Revert "build: ditch proto-compiler, use buf" This reverts commit 53b56cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overhaul of the protobuf codegen logic from #2619 was incomplete: we encountered problems with serde implementations. Wasn't able to sort them quickly, and we're about to release Testnet 53, so I'm backing out the recent changes to unblock in-flight PRs. Will return to disentangling the protobuf story on subsequent sprint.
Revert "fix: re-enable grpc server reflection"
This reverts commit f8d09f6.
Revert "ci: update buf target dir"
This reverts commit 3e7b4c7.
Revert "dev: add buf breaking change detection"
This reverts commit 724ccf6.
Revert "ci: eliminate the chore of buf mod update"
This reverts commit 1f28bb2.
Revert "build: ditch proto-compiler, use buf"
This reverts commit 53b56cb.