Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename BSOD epoch_height to epoch_starting_height #2657

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented Jun 1, 2023

Closes #2648

Note: CI will fail here due to a breaking proto change

@redshiftzero redshiftzero temporarily deployed to smoke-test June 1, 2023 17:55 — with GitHub Actions Inactive
@redshiftzero redshiftzero temporarily deployed to smoke-test June 1, 2023 18:13 — with GitHub Actions Inactive
@redshiftzero redshiftzero force-pushed the rename-epoch-height branch from 84c7caa to bd337ce Compare June 5, 2023 17:55
@redshiftzero redshiftzero temporarily deployed to smoke-test June 5, 2023 17:55 — with GitHub Actions Inactive
@hdevalence
Copy link
Member

@redshiftzero can you rebase this? otherwise LGTM

@redshiftzero redshiftzero force-pushed the rename-epoch-height branch from bd337ce to 8e17fe7 Compare June 8, 2023 20:56
@redshiftzero redshiftzero temporarily deployed to smoke-test June 8, 2023 20:56 — with GitHub Actions Inactive
@redshiftzero redshiftzero force-pushed the rename-epoch-height branch from 8e17fe7 to ba1d931 Compare June 9, 2023 16:03
@redshiftzero redshiftzero force-pushed the rename-epoch-height branch from ba1d931 to bcac636 Compare June 9, 2023 16:10
@redshiftzero redshiftzero temporarily deployed to smoke-test June 9, 2023 16:10 — with GitHub Actions Inactive
@redshiftzero
Copy link
Member Author

CI is failing here due to the fact this is a breaking change to the protos, so merging

@redshiftzero redshiftzero merged commit fea9c27 into main Jun 9, 2023
@redshiftzero redshiftzero deleted the rename-epoch-height branch June 9, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename the epoch_height field on BatchSwapOutputData
2 participants