chore: rename BSOD epoch_height to epoch_starting_height
#2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
force-pushed
the
rename-epoch-height
branch
from
84c7caa to
bd337ce
Compare
|
@redshiftzero can you rebase this? otherwise LGTM |
redshiftzero
force-pushed
the
rename-epoch-height
branch
from
bd337ce to
8e17fe7
Compare
redshiftzero
force-pushed
the
rename-epoch-height
branch
from
8e17fe7 to
ba1d931
Compare
redshiftzero
force-pushed
the
rename-epoch-height
branch
from
ba1d931 to
bcac636
Compare
|
CI is failing here due to the fact this is a breaking change to the protos, so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2648
Note: CI will fail here due to a breaking proto change