updates cli defaults to use HTTPS URLs #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Testnet 53 Himalia, the HTTPS endpoint for pd's gRPC service is live. We can now update the CLI defaults for all the binaries to use the HTTPS URLs for both pd and tendermint. Refs #1886.
10 tasks
hdevalence
approved these changes
Jun 8, 2023
conorsch
added a commit
to penumbra-zone/osiris
that referenced
this pull request
Jul 14, 2023
We've been using HTTPS URLs in the deployment spec for Osiris for a while now, ever since [0]. Here we update the default value in the CLI options, so we don't need to depend on the override. [0] penumbra-zone/penumbra#2685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Testnet 53 Himalia, the HTTPS endpoint for pd's gRPC service is live. We can now update the CLI defaults for all the binaries to use the HTTPS URLs for both pd and tendermint.
Refs #1886.