integrate ibc-types2 #2706
Merged
integrate ibc-types2 #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avahowell
commented
Jun 28, 2023
| @@ -62,10 +57,12 @@ impl MsgHandler for MsgChannelOpenAck { | |||
| version: self.version_on_b.clone(), | |||
| }; | |||
|
|
|||
| let proof = MerkleProof::try_from(self.proof_chan_end_on_b.clone())?; | |||
There was a problem hiding this comment.
I think this should move to the MsgChannelOpenAck domain type
avahowell
commented
Jun 28, 2023
| proof_verification::verify_connection_state( | ||
| &trusted_client_state, | ||
| self.proofs_height_on_b, | ||
| &ibc_types2::core::commitment::MerklePrefix { |
There was a problem hiding this comment.
this should be using try_from
avahowell
commented
Jun 28, 2023
| .connection_id() | ||
| .ok_or_else(|| anyhow::anyhow!("invalid counterparty"))?, | ||
| ), | ||
| &MerklePrefix { |
There was a problem hiding this comment.
ditto, this should be using try_into instead of manually constructing MerklePrefix
avahowell
commented
Jun 28, 2023
| .ok_or_else(|| anyhow::anyhow!("invalid counterparty"))?, | ||
| ), | ||
| &MerklePrefix { | ||
| key_prefix: connection.counterparty.prefix, |
There was a problem hiding this comment.
perhaps counterparty.prefix should be a MerklePrefix type at the domain type level instead?
|
Updated after code review with @plaidfinch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.