ci: fail on warnings when building rust code #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
added a commit
that referenced
this pull request
Jun 15, 2023
Since our docs recommend `cargo run --release --bin` invocations, warnings will be displayed on every run. Let's fail in CI if warnings are present, so we can address them prior to merge. Also updated the rust workflows to use maintained github action helpers. Closes #2716.
conorsch
force-pushed
the
2697-no-warnings-allowed
branch
from
7816c47 to
0d97d47
Compare
conorsch
added a commit
that referenced
this pull request
Jun 15, 2023
Since our docs recommend `cargo run --release --bin` invocations, warnings will be displayed on every run. Let's fail in CI if warnings are present, so we can address them prior to merge. Also updated the rust workflows to use maintained github action helpers. Closes #2716.
conorsch
force-pushed
the
2697-no-warnings-allowed
branch
from
0d97d47 to
bd4b659
Compare
conorsch
added a commit
that referenced
this pull request
Jun 15, 2023
Since our docs recommend `cargo run --release --bin` invocations, warnings will be displayed on every run. Let's fail in CI if warnings are present, so we can address them prior to merge. Also updated the rust workflows to use maintained github action helpers. Closes #2716.
conorsch
force-pushed
the
2697-no-warnings-allowed
branch
from
bd4b659 to
0bace76
Compare
conorsch
added a commit
that referenced
this pull request
Jun 15, 2023
Since our docs recommend `cargo run --release --bin` invocations, warnings will be displayed on every run. Let's fail in CI if warnings are present, so we can address them prior to merge. Also updated the rust workflows to use maintained github action helpers. Closes #2716.
conorsch
force-pushed
the
2697-no-warnings-allowed
branch
from
0bace76 to
31af861
Compare
Since our docs recommend `cargo run --release --bin` invocations, warnings will be displayed on every run. Let's fail in CI if warnings are present, so we can address them prior to merge. Also updated the rust workflows to use maintained github action helpers. Closes #2716.
conorsch
force-pushed
the
2697-no-warnings-allowed
branch
from
31af861 to
5875c38
Compare
conorsch
force-pushed
the
2697-no-warnings-allowed
branch
from
02ca9d1 to
5875c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our docs recommend
cargo run --release --bininvocations, warnings will be displayed on every run. Let's fail in CI if warnings are present, so we can address them prior to merge.Also updated the rust workflows to use maintained github action helpers.
Closes #2697.