Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dex: make put_position async #2744

Merged
merged 4 commits into from
Jun 28, 2023
Merged

dex: make put_position async #2744

merged 4 commits into from
Jun 28, 2023

Conversation

hdevalence
Copy link
Member

@hdevalence hdevalence commented Jun 27, 2023 •
edited by erwanor
Loading

This PR makes put_position async, allowing it to perform state reads. It also renames index_position to index_position_by_price. Helpful for #2378 and #2753

@hdevalence hdevalence temporarily deployed to smoke-test June 27, 2023 17:11 — with GitHub Actions Inactive
@erwanor erwanor changed the title WIP: liquidity indexing dex: make put_position async Jun 28, 2023
@hdevalence @erwanor
dex: delete unused, unoptimized method
2b44911
@hdevalence @erwanor
dex: make PositionManager::put_position async
814eb19 
This allows the `put_position` method to perform state reads to update indexes
as it writes positions.
@hdevalence @erwanor
dex: rename to index_position_by_price
11b131d
@erwanor erwanor marked this pull request as ready for review June 28, 2023 19:48
@erwanor
Copy link
Member

erwanor commented Jun 28, 2023

Rebased against main, will merge on CI passes.

@erwanor erwanor temporarily deployed to smoke-test June 28, 2023 19:56 — with GitHub Actions Inactive
@erwanor erwanor merged commit 782c514 into main Jun 28, 2023
@erwanor erwanor deleted the liquidity-index branch June 28, 2023 20:13
@cratelyn cratelyn added the A-dex Area: Relates to the dex label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-dex Area: Relates to the dex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdevalence @erwanor @cratelyn