Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check rustdoc build on PRs #2790

Merged
merged 1 commit into from
Jul 6, 2023
Merged

ci: check rustdoc build on PRs #2790

merged 1 commit into from
Jul 6, 2023

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Jul 5, 2023

When we refactor rust crates, it's easy to break the rustdoc build by forgetting to update pinned versions in our rustdoc build script: ./deployments/scripts/rust-docs. Let's run that script as part of the Rust checks in each PR, so we get notified promptly about breakage. We'll still only deploy new docs after PRs have been merged into main.

When we refactor rust crates, it's easy to break the rustdoc build by
forgetting to update pinned versions in our rustdoc build script:
`./deployments/scripts/rust-docs`. Let's run that script as part of the
Rust checks in each PR, so we get notified promptly about breakage.
We'll still only deploy new docs after PRs have been merged into main.
@conorsch conorsch temporarily deployed to smoke-test July 5, 2023 20:06 — with GitHub Actions Inactive
@conorsch conorsch merged commit 854ef5b into main Jul 6, 2023
@conorsch conorsch deleted the ci-build-rustdoc-on-prs branch July 6, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant