Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc: use ibc-types 0.3.0 instead of main #2793

Merged
merged 4 commits into from
Jul 7, 2023
Merged

ibc: use ibc-types 0.3.0 instead of main #2793

merged 4 commits into from
Jul 7, 2023

Conversation

avahowell
Copy link
Contributor

No description provided.

@avahowell avahowell temporarily deployed to smoke-test July 6, 2023 00:23 — with GitHub Actions Inactive
@conorsch
Copy link
Contributor

conorsch commented Jul 7, 2023

Failing WASM check: @avahowell suspects we just need to click on the std feature for the ibc-types dep.

@conorsch
Copy link
Contributor

conorsch commented Jul 7, 2023

Heads up, we just merged penumbra-zone/ibc-types#38 which we'll definitely want in for Testnet 56. If subsequent testing with #2803 looks good, we'll either want to bump ibc-types to 0.3.1 to include the latest, or keep the dep on main for now. What we don't want is to pin 0.3.0 of ibc-types for 56, which would ship a known-bad ibc implementation.

@avahowell avahowell temporarily deployed to smoke-test July 7, 2023 21:08 — with GitHub Actions Inactive
@avahowell avahowell merged commit 15df6a0 into main Jul 7, 2023
@avahowell avahowell deleted the use-ibctypes-030 branch July 7, 2023 21:33
@conorsch
Copy link
Contributor

conorsch commented Jul 10, 2023

What we don't want is to pin 0.3.0 of ibc-types for 56, which would ship a known-bad ibc implementation

We're OK for Testnet 56: we're using a git dep of the ibc-types crates, so the 0.3.0 version will use the latest from the remote. We've not created a tag for 0.3.0, although we probably should soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants