-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move remaining code in penumbra-crypto
to penumbra-chain
#2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
I split out #2800 into another PR since this PR is failing the wasm build and I need to debug further to understand why. |
redshiftzero
changed the title
refactor: move remaining code in
wip - refactor: move remaining code in Jul 7, 2023
penumbra-crypto
to penumbra-component
penumbra-crypto
to penumbra-component
redshiftzero
changed the title
wip - refactor: move remaining code in
wip - refactor: move remaining code in Jul 10, 2023
penumbra-crypto
to penumbra-component
penumbra-crypto
to penumbra-chain
We aim to land this PR prior to shipping Testnet 56 (#2761). |
For posterity, the issue with the wasm build was: On main,
In this PR previously:
Two ways to address this would be to:
I've done approach 1 here to resolve since the amount of code in question is fairly small. |
redshiftzero
changed the title
wip - refactor: move remaining code in
refactor: move remaining code in Jul 10, 2023
penumbra-crypto
to penumbra-chain
penumbra-crypto
to penumbra-chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2765