Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to query for balances by account and asset type #2799

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add ability to query for balances by account and asset type #2799

merged 1 commit into from
Jul 12, 2023

Conversation

aubrika
Copy link
Contributor

@aubrika aubrika commented Jul 7, 2023

Closes #2768

@conorsch
Copy link
Contributor

conorsch commented Jul 7, 2023 •
edited
Loading

@aubrika Thanks for tackling this on short notice. Still very interested in shipping this feature, but it's OK if it slips off 56: we can work with SL to use custom container versions, so whenever this lands, we'll have an associated hash; plus, all of the view.* protos are currently inaccessible to us in go until we resolve strangelove-ventures/interchaintest#658

@aubrika aubrika force-pushed the 2768-balances-request branch from 21c1a0b to c05afb4 Compare July 10, 2023 22:56
@aubrika aubrika force-pushed the 2768-balances-request branch from c05afb4 to 75f418c Compare July 10, 2023 23:00
@aubrika aubrika force-pushed the 2768-balances-request branch from 75f418c to 3604d20 Compare July 10, 2023 23:07
@aubrika aubrika temporarily deployed to smoke-test July 10, 2023 23:07 — with GitHub Actions Inactive
@aubrika aubrika force-pushed the 2768-balances-request branch from 3604d20 to e9e3fbd Compare July 10, 2023 23:37
@aubrika aubrika temporarily deployed to smoke-test July 10, 2023 23:38 — with GitHub Actions Inactive
@aubrika aubrika marked this pull request as ready for review July 11, 2023 00:28
@aubrika aubrika requested a review from conorsch July 11, 2023 00:28
@aubrika
Copy link
Contributor Author

aubrika commented Jul 12, 2023

Broken CI is just due to proto changes, merging in as-is in advance of potential future feature requests

@aubrika aubrika merged commit 7969fd3 into main Jul 12, 2023
@aubrika aubrika deleted the 2768-balances-request branch July 12, 2023 17:20
This was referenced Jul 21, 2023
Merged
Open
Open
@conorsch conorsch mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch Awaiting requested review from conorsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow filtering view service balance queries by asset
2 participants
@aubrika @conorsch