fix: update rocksdb from v0.19 to v0.21 #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the C++ toolchain used by the underlying system, builds of rocksdb might fail because of an issue documented in: facebook/rocksdb#11118 (In short, the code relied on headers importing other headers, rather than what the standard guarantees headers to export; thus code may not compiler on all toolchains). Version 0.21 of the crate fixes this issue, by relying on a later version of the underlying rocksdb library. For the rust crate, this issue showed up in: rust-rocksdb/rust-rocksdb#772 On Linux/Manjaro I ran into this issue as well, but I expect that other people following along with the docs might run into it as well, so probably worth updating, unless there's some issue with doing so.
redshiftzero
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the C++ toolchain used by the underlying system, builds of rocksdb might fail because of an issue documented in:
facebook/rocksdb#11118
(In short, the code relied on headers importing other headers, rather than what the standard guarantees headers to export; thus code may not compiler on all toolchains).
Version 0.21 of the crate fixes this issue, by relying on a later version of the underlying rocksdb library.
For the rust crate, this issue showed up in:
rust-rocksdb/rust-rocksdb#772
On Linux/Manjaro I ran into this issue as well, but I expect that other people following along with the docs might run into it as well, so probably worth updating, unless there's some issue with doing so.