fix(pcli): help text for ibc withdrawals #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
commented
Jul 13, 2023
| let amount = Amount::try_from(amount.clone()).unwrap(); | ||
| let denom = asset::REGISTRY.parse_denom(denom).ok_or_else(|| { | ||
| anyhow::anyhow!(format!("unable to parse denomination '{}'", denom)) | ||
| })?; |
There was a problem hiding this comment.
Withdrawing penumbra throws an error, but sending upenumbra does not. That's confusing. We should look for opportunities to reconcile the "base denom" vs "display denom" nomenclature throughout user-facing views.
There was a problem hiding this comment.
Ideally there shouldn't be any reconciliation necessary, since the command line tooling should work with any known unit.
There was a problem hiding this comment.
If we address the TODO about parsing the denom and amount from a concatenated string, as we do with pcli tx send, this problem should go away.
conorsch
force-pushed
the
pcli-withdrawal-help-text
branch
from
22e1785 to
c9ab9b8
Compare
Updates the docstrings for the `pcli tx withdraw` workflow. Still TK is better handling of the denoms, but deferring that change for now and just focusing on making the help text actually helpful.
conorsch
force-pushed
the
pcli-withdrawal-help-text
branch
from
c9ab9b8 to
6fde29a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the docstrings for the
pcli tx withdrawworkflow. Still TK is better handling of the denoms, but deferring that change for now and just focusing on making the help text actually helpful.