refactor: add TransactionParameters and DetectionData fields in TransactionBody
#2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit I also modified the `TransactionBodyView` such that it represents the same structure as the current `TransactionBody`. Since there is no private data in either the `DetectionData` or the `TransactionParameters`, there are no view structures added for those structs.
redshiftzero
force-pushed
the
2784-tx-params
branch
from
047a0cd to
eb2ddfd
Compare
hdevalence
reviewed
Jul 19, 2023
proto/penumbra/penumbra/core/transaction/v1alpha1/transaction.proto
Outdated
Show resolved
Hide resolved
hdevalence
requested changes
Jul 19, 2023
There was a problem hiding this comment.
This looks good, but I think we should pull out the encrypted memo into another proto message so that the TransactionBody only has sub-messages as fields. (We don't have to do anything on the domain types, I think just changing the protos is sufficient for forward compatibility).
cronokirby
reviewed
Jul 19, 2023
cronokirby
reviewed
Jul 19, 2023
There was a problem hiding this comment.
I agree with @hdevalence about the protobuf comments.
Had a very minor nit in terms of code simplification as well.
Otherwise, looks good to me! :)
|
This has had review comments addressed - lmk if there is any other feedback else I'll plan to merge in the next few hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2784
The scope of this is refactoring the
TransactionBodyto contain two new fields:TransactionParameters(new struct) that contains the expiry height and chain ID (both previously fields directly on theTransactionBody).DetectionData(new struct) that contains the Fuzzy Message Detection (FMD) clues for that transaction (previously a field directly on theTransactionBody).In this PR I have not modified the EffectHash implementation (see #2808). The idea is (per the comment at the end of #2784):
Note: CI job
Protobuf / Lint protobuf (pull_request)will fail during the check for breaking changes to the protobufs, but breaking changes to the protobufs are unavoidable here.