ibc: elide source port in Ics20Withdrawal #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avahowell
force-pushed
the
elide-source-port
branch
from
f219b70 to
e5c9b4c
Compare
|
@avahowell Do you mind rebasing this and regenerating the proto descriptor file? Looks like it'll pass CI then. |
avahowell
force-pushed
the
elide-source-port
branch
from
e5c9b4c to
05b7592
Compare
|
rebased and updated proto descriptor |
|
The sole failing CI check is flagging breaking changes to the protos. We're in good contact with SL about potential implications, so proceeding with merge for inclusion in Testnet 58. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since withdrawals always use the transfer port, there is no reason to include
source_portin the Ics20Withdrawal action