-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pd: use a range query for client synchronization #2881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
changed the title
pd: use prefix queries for client synchronization
pd: use a range query for client synchronization
Aug 4, 2023
erwanor
force-pushed
the
prefix_query_compact_b
branch
from
August 11, 2023 12:31
d820271
to
03f9098
Compare
erwanor
force-pushed
the
prefix_query_compact_b
branch
from
August 23, 2023 21:25
833e7a3
to
e5c71cb
Compare
Merging optimistically since the range query functionality is relatively well tested. The main unknown is whether the anticipated performance improvement will materialize or not. If it doesn't this PR will be easy to revert. This closes the loop on a series of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
stream_compact_block
method tocompact_block::StateReadExt
block_fetcher
tokio tasks inObliviousQueryService::compact_block_range
CompactBlock
s