Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: use a range query for client synchronization #2881

Merged
merged 10 commits into from
Aug 24, 2023
Merged

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Jul 28, 2023

This PR:

  • implements a stream_compact_block method to compact_block::StateReadExt
  • remove the block_fetcher tokio tasks in ObliviousQueryService::compact_block_range
  • use a single range query to catch-up on existing CompactBlocks

@erwanor erwanor marked this pull request as draft August 1, 2023 20:27
@erwanor erwanor self-assigned this Aug 3, 2023
@erwanor erwanor changed the title pd: use prefix queries for client synchronization pd: use a range query for client synchronization Aug 4, 2023
@erwanor erwanor force-pushed the prefix_query_compact_b branch from d820271 to 03f9098 Compare August 11, 2023 12:31
@erwanor erwanor marked this pull request as ready for review August 14, 2023 17:50
@erwanor erwanor temporarily deployed to smoke-test August 23, 2023 23:51 — with GitHub Actions Inactive
@erwanor
Copy link
Member Author

erwanor commented Aug 24, 2023

Merging optimistically since the range query functionality is relatively well tested. The main unknown is whether the anticipated performance improvement will materialize or not. If it doesn't this PR will be easy to revert. This closes the loop on a series of pd improvements as a response to #2867.

@erwanor erwanor merged commit ce2d319 into main Aug 24, 2023
@erwanor erwanor deleted the prefix_query_compact_b branch August 24, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Testnet 60: Tethys
Development

Successfully merging this pull request may close these issues.

1 participant