-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: implement StateRead::nonverifiable_range
#2885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
force-pushed
the
range_queries_stateread
branch
from
August 4, 2023 01:04
39036c1
to
b67b934
Compare
erwanor
force-pushed
the
range_queries_stateread
branch
from
August 7, 2023 13:32
b67b934
to
70c3e2c
Compare
erwanor
force-pushed
the
range_queries_stateread
branch
from
August 11, 2023 12:31
226a866
to
638c5f5
Compare
erwanor
changed the title
storage: implement
storage: implement Aug 11, 2023
StateRead::nonverfiable_range
(wip)StateRead::nonverifiable_range
(wip)
erwanor
changed the title
storage: implement
storage: implement Aug 11, 2023
StateRead::nonverifiable_range
(wip)StateRead::nonverifiable_range
Is there any reason not to merge this for the current testnet? |
Not really, I left it open to invite reviews but merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for range queries over the
nonverifiable
storage. It does so by:StateRead
trait with a new method:StateDelta
-level stream that interleaves caching layers and underlying storage.Example API:
The first intended use of range queries is to fetch a range of
compact_blocks
from an arbitrary height:Alternative APIs considered:
and
either are fine choices, but my preference goes to the simpler signature.