Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make U128x128::round_up fallible #2910

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: make U128x128::round_up fallible #2910

merged 1 commit into from
Aug 21, 2023

Conversation

redshiftzero
Copy link
Member

Followup from one of the audits.

Inside the DEX logic for the infallible methods that call U128x128::round_up, what should happen? (cc @erwanor)

@redshiftzero redshiftzero requested a review from erwanor August 9, 2023 17:01
@redshiftzero redshiftzero temporarily deployed to smoke-test August 9, 2023 17:01 — with GitHub Actions Inactive
erwanor
erwanor requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@erwanor erwanor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check a couple assumptions, marking this as needing review to make sure it doesn't get merged accidentally before I can focus on this.

@erwanor erwanor merged commit d692fcf into main Aug 21, 2023
@erwanor erwanor deleted the 6-uprounding branch August 21, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanor erwanor erwanor approved these changes

Assignees

@redshiftzero redshiftzero

@erwanor erwanor

Labels
None yet
Projects
No open projects
Testnets
Status: Testnet 59: Enceladus
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redshiftzero @erwanor