post-audit circuit fixes part 1 #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lúcás Meier <cronokirby@gmail.com>
Co-authored-by: Lúcás Meier <cronokirby@gmail.com>
Co-authored-by: Lúcás Meier <cronokirby@gmail.com>
The previous tests have a zero fractional part, now we construct test fixed-point values based on a non-zero integral and fractional part.
For tests that involve invalid proof inputs, there are two ways they can fail based on whether we are in release and debug mode. In debug mode, there is upstream in ark-groth16 an assertion that the circuit is satisifed prior to returning the proof. For invalid inputs, the tests will panic at the proving stage. In release mode, the proof will be constructed, but since it was generated with invalid inputs, it will not verify. In that case, we must panic if the return value of the verification method was `false`, which corresponds to the expected behavior for tests that operate on invalid inputs.
We should build in the docs the primary version that we are using in the penumbra monorepo. The only reason a different version (0.4.0) of decaf377 is being pulled in to cause ambiguity, is that frost377 is used in several places as a dev dependency only.
redshiftzero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup fixes to the circuits from the NCC audit