Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zk ceremony phase 1 benchmarking #2922

Merged
merged 9 commits into from
Aug 21, 2023
Merged

zk ceremony phase 1 benchmarking #2922

merged 9 commits into from
Aug 21, 2023

Conversation

redshiftzero
Copy link
Member

Towards #2877

@redshiftzero redshiftzero temporarily deployed to smoke-test August 11, 2023 22:41 — with GitHub Actions Inactive
@redshiftzero redshiftzero mentioned this pull request Aug 12, 2023
Closed
@redshiftzero redshiftzero temporarily deployed to smoke-test August 16, 2023 15:18 — with GitHub Actions Inactive
@redshiftzero redshiftzero temporarily deployed to smoke-test August 16, 2023 16:46 — with GitHub Actions Inactive
cronokirby
cronokirby requested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to benchmark the linking proof in verification as well, using the is_linked_to method. This probably won't add much to the cost of verification, but is part of it.

@redshiftzero redshiftzero temporarily deployed to smoke-test August 18, 2023 00:50 — with GitHub Actions Inactive
cronokirby
cronokirby approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@redshiftzero redshiftzero merged commit c53f7c8 into main Aug 21, 2023
@redshiftzero redshiftzero deleted the zk-phase-1-bench branch August 21, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cronokirby cronokirby cronokirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redshiftzero @cronokirby