Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: create upgrade messages #2957

Merged
merged 5 commits into from
Aug 26, 2023
Merged

governance: create upgrade messages #2957

merged 5 commits into from
Aug 26, 2023

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Aug 25, 2023

This PR adds an UpgradePlan proposal type that specifies a height for an upgrade. If an upgrade is ratified, then the chain will trigger an epoch change at that height and gracefully shutdown.

@erwanor erwanor temporarily deployed to smoke-test August 25, 2023 18:33 — with GitHub Actions Inactive
@erwanor erwanor temporarily deployed to smoke-test August 26, 2023 08:28 — with GitHub Actions Inactive
@erwanor erwanor temporarily deployed to smoke-test August 26, 2023 17:18 — with GitHub Actions Inactive
@erwanor erwanor temporarily deployed to smoke-test August 26, 2023 17:45 — with GitHub Actions Inactive
@erwanor erwanor marked this pull request as ready for review August 26, 2023 17:46
@erwanor
Copy link
Member Author

erwanor commented Aug 26, 2023

I am going to add the actual mechanism for triggering a chain halt / epoch change in a follow-up PR. The rough idea is that we will write a height: u64 to a chain/next_upgrade_height key in nonverifiable storage, compute a predicate during the commit phase (should_chain_upgrade = current_height.sat_add(1) == upgrade_height), and exit if that's the case; this is much like how emergency halts work.

This PR does not add any stateless/stateful check for the UpgradePlan handling.

@erwanor erwanor merged commit 75cd512 into main Aug 26, 2023
8 checks passed
@erwanor erwanor deleted the upgrade_message branch August 26, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant