Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chain: implement upgrade halts #2959

Merged
merged 7 commits into from
Aug 31, 2023
Merged

chain: implement upgrade halts #2959

merged 7 commits into from
Aug 31, 2023

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Aug 26, 2023

This PR implement chain halts when the upgrade height specified in an UpgradePlan has been reached. It does this in three steps:

  • when an UpgradePlan is enacted, we write the scheduled upgrade height in nonverifiable storage at key chain/next_upgrade_height
  • when the target height is reached:
    • trigger an early epoch change so that the upgraded chain starts at a clean epoch boundary
    • after committing, shutdown gracefully

@erwanor erwanor temporarily deployed to smoke-test August 26, 2023 22:36 — with GitHub Actions Inactive
@erwanor erwanor requested a review from plaidfinch August 26, 2023 22:43
@erwanor erwanor marked this pull request as ready for review August 26, 2023 23:03
plaidfinch
plaidfinch approved these changes Aug 27, 2023
View reviewed changes
Copy link
Collaborator

@plaidfinch plaidfinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me!

@erwanor erwanor temporarily deployed to smoke-test August 31, 2023 18:06 — with GitHub Actions Inactive
@erwanor erwanor temporarily deployed to smoke-test August 31, 2023 20:34 — with GitHub Actions Inactive
@erwanor
Copy link
Member Author

erwanor commented Aug 31, 2023

There has been some minor additions since review, mainly:

  • a small fix to the logic fetching spendable note records for voting
  • re-using the signal mechanism to force a binary upgrade when after an upgrade halt is complete.

@erwanor erwanor merged commit 4b530bc into main Aug 31, 2023
8 checks passed
@erwanor erwanor deleted the chain_upgrade_halt branch August 31, 2023 21:18
@erwanor erwanor self-assigned this Aug 31, 2023
@erwanor erwanor mentioned this pull request Aug 31, 2023
Closed
@erwanor erwanor mentioned this pull request Sep 12, 2023
Open
19 tasks
@erwanor erwanor added this to the Upgrades milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plaidfinch plaidfinch plaidfinch approved these changes

Assignees

@erwanor erwanor

Labels
None yet
Projects
No open projects
Testnets
Status: Testnet 60: Tethys
Milestone
Upgrades
Development

Successfully merging this pull request may close these issues.
2 participants
@erwanor @plaidfinch