Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: BIP44 derivation #2964

Merged
merged 16 commits into from
Sep 15, 2023
Merged

crypto: BIP44 derivation #2964

merged 16 commits into from
Sep 15, 2023

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented Sep 1, 2023 •
edited
Loading

Towards #2946.

This adds experimental BIP44 derivation wherein we:

  1. derive a 64-byte binary seed from the seed phrase as described in BIP39 using PBKDF2 but using only mnemonic as the salt
  2. define a BIP44 path m/44'/6532'/0' which matches the Penumbra coin_type and the account number (0) used in the test vector generator (the apostrophes indicate hardened derivation)
  3. derive the spend key bytes from BIP32 child key derivation from the seed and the above BIP44 path

@hdevalence hdevalence mentioned this pull request Sep 5, 2023
Merged
@redshiftzero redshiftzero force-pushed the bip44 branch 2 times, most recently from 2cb6be9 to 0a544d7 Compare September 14, 2023 21:01
@redshiftzero redshiftzero changed the title wip: BIP44 derivation BIP44 derivation Sep 14, 2023
@redshiftzero redshiftzero marked this pull request as ready for review September 14, 2023 21:19
@redshiftzero redshiftzero changed the title BIP44 derivation wip: BIP44 derivation Sep 14, 2023
@redshiftzero redshiftzero changed the title wip: BIP44 derivation crypto: BIP44 derivation Sep 15, 2023
@redshiftzero redshiftzero temporarily deployed to smoke-test September 15, 2023 16:53 — with GitHub Actions Inactive
cronokirby
cronokirby approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, looks good to me otherwise!

crates/bin/pcli/src/command/keys.rs Outdated Show resolved Hide resolved
crates/bin/pcli/src/command/keys.rs Outdated Show resolved Hide resolved
redshiftzero and others added 16 commits September 15, 2023 16:00
@redshiftzero @cronokirby
crypto: rename SpendKey::from_seed_phrase to indiciate BIP39
67be6d5
@redshiftzero @cronokirby
pcli: add option for --legacy-bip39-derivation to import
24426b1 
```
Import wallet from an existing 24-word seed phrase. Will prompt for input interactively. Also
accepts input from stdin, for use with pipes

USAGE:
    pcli keys import phrase [OPTIONS]

OPTIONS:
    -h, --help
            Print help information

    -l, --legacy-bip39-derivation <legacy-bip39-derivation>
            If true, will use legacy BIP39 derivation [default: false]
```
@redshiftzero @cronokirby
pcli: add experimental --bip44-derivation option
4aed395
@redshiftzero @cronokirby
crypto: add initial BIP44 module
ff60f4d
@redshiftzero @cronokirby
crypto: derive HD wallet master key m
1346274
@redshiftzero @cronokirby
crypto: CKDpriv function
369cfec
@redshiftzero @cronokirby
crypto: secp256k1 parts of ckd_priv fcn
64eee04
@redshiftzero @cronokirby
crypto: move through BIP44 path hierarchy to derive keys
1b71fdf
@redshiftzero @cronokirby
test: add BIP39 seed vectors
806b552
@redshiftzero @cronokirby
test: adding test vectors for BIP32 key derivation
5836ba2
@redshiftzero @cronokirby
crypto: use bip32 crate for child key derivation, add ledger test
63598a6
@redshiftzero @cronokirby
pcli: implement bip44 derivation option
b98f1aa
@redshiftzero @cronokirby
crypto: change and address_index are optional
86dc250
@redshiftzero @cronokirby
crypto: derive seed from mnemonic phrase for BIP44 SpendKey
d929559
@redshiftzero @cronokirby
pcli: use clap action for --bip44-derivation flag
fa77a19
@cronokirby
crypto: Simplify some code in BIP44 derivation
8562dbc
@cronokirby cronokirby temporarily deployed to smoke-test September 15, 2023 23:02 — with GitHub Actions Inactive
@cronokirby cronokirby merged commit 9c80e80 into main Sep 15, 2023
8 checks passed
@cronokirby cronokirby deleted the bip44 branch September 15, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cronokirby cronokirby cronokirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Testnets
Status: Testnet 56: Callisto
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redshiftzero @cronokirby