Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegator_vote: use balance commitment to staked note #2969

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Sep 5, 2023

The DelegatorVote stateless checks verify both the action effect hash signature and the supplied proof against the validated public inputs. This PR changes the balance commitment used in the proof verification to match the one used in proof generation: a commitment to the balance of the staked_note which is used to authenticate the spend.

Co-authored-by: finch <finch@plaidfinch.net>
@erwanor erwanor temporarily deployed to smoke-test September 6, 2023 19:57 — with GitHub Actions Inactive
@erwanor erwanor changed the title delegator_vote: use balance commitment to voting power delegator_vote: use balance commitment to staked note Sep 6, 2023
@erwanor erwanor merged commit b4cb9aa into main Sep 6, 2023
8 checks passed
@erwanor erwanor deleted the zk_delegator_vote_check branch September 6, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant