Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: stub proto definitions for setup coordinator #3006

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

hdevalence
Copy link
Member

Results of pairing with @redshiftzero and @cronokirby .

@conorsch
Copy link
Contributor

Rebased to resolve conflicts from merging #3016.

@conorsch conorsch temporarily deployed to smoke-test September 13, 2023 21:24 — with GitHub Actions Inactive
@conorsch
Copy link
Contributor

conorsch commented Sep 15, 2023

Saw a new buf lint on this PR:

Error: Service name "CeremonyCoordinator" should be suffixed with "Service".
Error: buf found 1 lint failures.

We've honored that rule elsewhere, so make since to me. I'll tack it on.

@conorsch conorsch temporarily deployed to smoke-test September 15, 2023 00:19 — with GitHub Actions Inactive
@conorsch conorsch merged commit 4bb834b into main Sep 15, 2023
8 checks passed
@conorsch conorsch deleted the setup-proto branch September 15, 2023 17:44
@cratelyn cratelyn added the protobuf-changes Makes changes to the protobuf definitions. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf-changes Makes changes to the protobuf definitions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants