feat(pd) display urls clearly in log messages #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During `testnet join` there are a few places where debug-formatting was applied to URLs, which made the log messages difficult to read. I stare at the these logging messages a lot, so I'm making them more readable from the get go.
conorsch
added a commit
that referenced
this pull request
Sep 15, 2023
Follow-up to #3032. Trying to keep the log messages maximally legible, particularly the service start messages.
conorsch
added a commit
that referenced
this pull request
Sep 15, 2023
Follow-up to #3032. Trying to keep the log messages maximally legible, particularly the service start messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
testnet jointhere are a few places where debug-formatting was applied to URLs, which made the log messages difficult to read. I stare at the these logging messages a lot, so I'm making them more readable from the get go.