refactor: move governance code to penumbra-governance
#3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
redshiftzero
force-pushed
the
app-governance
branch
from
97f1c4f to
ad44e0e
Compare
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
redshiftzero
force-pushed
the
app-governance
branch
from
e3c35b1 to
a802cb3
Compare
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
This avoids a circular dependency between `penumbra-governance` and `penumbra-transaction`
The reason for this is that previously the `put_dao_transaction` and `pending_dao_transactions` methods were defined in the `StateReadExt` and `StateWriteExt` traits in `penumbra-governance`. However, they require `Transaction` from `penumbra-transaction` which would result in a circular dependency. Instead, we make a tiny extension trait in the app crate with these two functions.
redshiftzero
force-pushed
the
app-governance
branch
from
a802cb3 to
b09eb92
Compare
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Error
redshiftzero
force-pushed
the
app-governance
branch
from
b09eb92 to
6a8634e
Compare
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
changed the title
penumbra-governancepenumbra-governance
|
Merging in order to allow proto refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2950
This addresses the remaining governance items in #2288
Note that there is one non-refactoring change here which is in this commit, which includes
UndelegateClaimin the list of actions that have proofs and thus should not be possible in aDaoSpendproposal due to DoS risk. Since claiming undelgate outputs is not possible,DelegateandUndelegateactions are also now disallowed.