Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcli: display ics20 withdrawals in pcli v tx #3099

Merged
merged 1 commit into from
Sep 30, 2023
Merged

pcli: display ics20 withdrawals in pcli v tx #3099

merged 1 commit into from
Sep 30, 2023

Conversation

hdevalence
Copy link
Member

Now it looks like

Scanning blocks from last sync height 2965 to latest height 2965
[0s] ██████████████████████████████████████████████████       0/0       0/s ETA: 0s
 Action Type       Description
 Spend             [account 1] spent 3000penumbra
 Output            1766penumbra to [account 1]
 Ics20 Withdrawal  1234penumbra via channel-0 to osmo1kh0fwkdy05yp579d8vczgharkcexfw582zj488

 Transaction Fee                0penumbra
 Transaction Memo Sender        penumbrav2t1cus5kaxcdh3x6th437s9eslze9mnvmcdxyhw9px79ewfgpd7utu253m52dhevxgf7yqrx04qks5267ysx9rmn7ckhqf0lkc6c9jzr63y8tuvq8d8yh6vatzf7l49xa2xs5xrls
 Transaction Memo Text
 Transaction Expiration Height  0

@hdevalence hdevalence requested a review from aubrika September 26, 2023 00:49
@hdevalence hdevalence temporarily deployed to smoke-test September 26, 2023 00:49 — with GitHub Actions Inactive
hdevalence
hdevalence commented Sep 26, 2023
View reviewed changes
crates/bin/pcli/src/command/view/tx.rs
penumbra_transaction::ActionView::Ics20Withdrawal(_) => {
["Ics20 Withdrawal".to_string(), "".to_string()]
penumbra_transaction::ActionView::Ics20Withdrawal(w) => {
let unit = w.denom.best_unit_for(w.amount);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side question: the Ics20Withdrawal domain type has an asset::DenomMetadata, but the ICS20 packet only has a string denom, correct? How does the domain type get the asset metadata? @aubrika

@hdevalence hdevalence merged commit de3a20e into main Sep 30, 2023
8 checks passed
@hdevalence hdevalence deleted the pcli-view-tx-ics20 branch September 30, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aubrika aubrika Awaiting requested review from aubrika

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hdevalence