-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pcli): support new ibc query logic #3143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
2937-pcli-ibc-queries
branch
from
October 5, 2023 00:11
1821e7f
to
0e5d28c
Compare
Requesting feedback from @avahowell. It might be useful to compare results between the current state of this PR and after applying this diff:
|
conorsch
force-pushed
the
2937-pcli-ibc-queries
branch
from
October 6, 2023 22:22
37c7044
to
94f1106
Compare
conorsch
force-pushed
the
2937-pcli-ibc-queries
branch
from
October 6, 2023 23:45
94f1106
to
47da4a5
Compare
conorsch
force-pushed
the
2937-pcli-ibc-queries
branch
from
October 6, 2023 23:50
47da4a5
to
a89b36d
Compare
Wasn't able to drag the |
conorsch
force-pushed
the
2937-pcli-ibc-queries
branch
from
October 10, 2023 15:41
a89b36d
to
5976aad
Compare
Previously pcli was only capable of looking up info on IBC clients, connections, and channels if the user provided a unique identifier for the resource in question. To facilitate IBC in practice, we want to enable querying for lists of these values, so the end user (or developer) can inspect the current options in a legible format. All but the `channel` query have been updated. Submitting as-is to ensure it lands in next testnet. Closes #2937. Co-authored-by: Ava Howell <ava@penumbralabs.xyz>
conorsch
force-pushed
the
2937-pcli-ibc-queries
branch
from
October 10, 2023 15:47
5976aad
to
e99790d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously pcli was only capable of looking up info on IBC clients, connections, and channels if the user provided a unique identifier for the resource in question. To facilitate IBC in practice, we want to enable querying for lists of these values, so the end user (or developer) can inspect the current options in a legible format.
Closes #2937.