feat(pd): special handling of seed nodes in join #3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When joining a network via `pd testnet join`, pd already inspects the peers known to the target bootstrap node, and includes those peers in the generated CometBFT config. Technically it's not correct to assume that these peers are seeds, but limiting to a threshold (#3063) ensures that only a few nodes will be miscategorized this way. The new behavior introduced here is that `pd testnet join` will inspect monikers of peers learned from the bootstrap node, and if the string "seed" appears in the moniker, guarantee that peer lands in the `seeds` field of the CometBFT config. To complement this change, we update the deployment logic to create a seed node, and ensure that seed node is excluded from the loadbalanced RPC, to avoid hitting it via the join request (in which case it won't report many peers, because seed nodes drop peer connections after serving address info). Refs #3056.
conorsch
added a commit
that referenced
this pull request
Oct 10, 2023
Follow up to #3155. We've been using moon names as a mnemonic for human-readable names for services related to Penumbra testnets. Due to a typo, the moon of Neptune "Naiad" was misspelled, and that typo made it into a few config files. This is a purely cosmetic change with zero impact on service behavior or performance.
conorsch
added a commit
that referenced
this pull request
Oct 10, 2023
Follow up to #3155. We've been using moon names as a mnemonic for human-readable names for services related to Penumbra testnets. Due to a typo, the moon of Neptune "Naiad" was misspelled, and that typo made it into a few config files. This is a purely cosmetic change with zero impact on service behavior or performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When joining a network via
pd testnet join, pd already inspects the peers known to the target bootstrap node, and includes those peers in the generated CometBFT config. Technically it's not correct to assume that these peers are seeds, but limiting to a threshold (#3063) ensures that only a few nodes will be miscategorized this way.The new behavior introduced here is that
pd testnet joinwill inspect monikers of peers learned from the bootstrap node, and if the string "seed" appears in the moniker, guarantee that peer lands in theseedsfield of the CometBFT config.To complement this change, we update the deployment logic to create a seed node, and ensure that seed node is excluded from the loadbalanced RPC, to avoid hitting it via the join request (in which case it won't report many peers, because seed nodes drop peer connections after serving address info).
Refs #3056.