Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abci query: support nonexistence proofs #3163

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

avahowell
Copy link
Contributor

@avahowell avahowell commented Oct 6, 2023

Previously, we would error in the ABCI query interface if a key was not found. This PR changes that behavior to instead return an empty vec for the requested value, along with a nonexistence proof to the root hash showing the value doesn't exist in the state.

This is required for relayers to build timeout packets. I verified that this change works locally using hermes.

@avahowell avahowell temporarily deployed to smoke-test October 6, 2023 17:00 — with GitHub Actions Inactive
@avahowell
Copy link
Contributor Author

Closes #3116

@conorsch conorsch merged commit 0cdabf9 into main Oct 6, 2023
8 checks passed
@conorsch conorsch deleted the abci-query-nonexistence-proofs branch October 6, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants