crypto: stabilize BIP44 derivation #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
redshiftzero
changed the title
redshiftzero
force-pushed
the
bip44-stabilize
branch
from
121e2ae to
c083039
Compare
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
redshiftzero
force-pushed
the
bip44-stabilize
branch
from
c083039 to
78739ce
Compare
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
hdevalence
approved these changes
Oct 7, 2023
Comment on lines
+39
to
+41
| The default wallet ID is set to 0. A typical use case for Penumbra will involve | ||
| generating the single default wallet, and then using multiple Penumbra accounts | ||
| within that wallet which share a single viewing key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2946
This changes the default derivation of the spend seed from the seed phrase to use BIP44 derivation (previously the BIP44 derivation was an experimental option). In turn, addresses derived using the BIP44-derived spend seed will be different from the addresses previously derived using the BIP39-derived spend seed. As such, the legacy import path is preserved for now in pcli via
pcli keys import phrase --legacy-raw-bip39-derivation.One can continue to use the legacy spend seed for now. The bot accounts and the test account are migrated over to the BIP44 derivation as part of this PR (deployment steps for the bots are tracked in #3123). This is done now as at some point the
--legacy-raw-bip39-derivationwill be removed.pcli keys import phrasewill look like: