Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: stabilize BIP44 derivation #3167

Merged
merged 11 commits into from
Oct 7, 2023
Merged

crypto: stabilize BIP44 derivation #3167

merged 11 commits into from
Oct 7, 2023

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented Oct 6, 2023

Closes #2946

This changes the default derivation of the spend seed from the seed phrase to use BIP44 derivation (previously the BIP44 derivation was an experimental option). In turn, addresses derived using the BIP44-derived spend seed will be different from the addresses previously derived using the BIP39-derived spend seed. As such, the legacy import path is preserved for now in pcli via pcli keys import phrase --legacy-raw-bip39-derivation.

One can continue to use the legacy spend seed for now. The bot accounts and the test account are migrated over to the BIP44 derivation as part of this PR (deployment steps for the bots are tracked in #3123). This is done now as at some point the --legacy-raw-bip39-derivation will be removed.

pcli keys import phrase will look like:

pcli-keys-import-phrase
Import wallet from an existing 24-word seed phrase. Will prompt for input interactively. Also
accepts input from stdin, for use with pipes. Use `--legacy-raw-bip39-derivation` if you generated
your wallet prior to Testnet 62

USAGE:
    pcli keys import phrase [OPTIONS]

OPTIONS:
    -h, --help
            Print help information

        --legacy-raw-bip39-derivation
            If set, will use legacy BIP39 derivation. Use this if you generated your wallet prior to
            Testnet 62

@redshiftzero redshiftzero changed the title crypto: stabilize experimental BIP44 derivation crypto: stabilize BIP44 derivation Oct 6, 2023
@redshiftzero redshiftzero marked this pull request as ready for review October 6, 2023 23:50
@redshiftzero redshiftzero temporarily deployed to smoke-test October 7, 2023 00:12 — with GitHub Actions Inactive
Comment on lines +39 to +41
The default wallet ID is set to 0. A typical use case for Penumbra will involve
generating the single default wallet, and then using multiple Penumbra accounts
within that wallet which share a single viewing key.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hdevalence hdevalence merged commit 719beb3 into main Oct 7, 2023
8 checks passed
@hdevalence hdevalence deleted the bip44-stabilize branch October 7, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIP44 support
2 participants