-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
summoner: provide phase 1 root during ceremony initialization #3183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was that instead initialization should be a separate command, rather than something done automatically.
The reason behind that is that then we could make this command take in a non-dummy root from an external source to populate things instead.
fe51b64
to
5c98b36
Compare
this is prohibitively slow when using the compressed/checked options
5c98b36
to
0f3587e
Compare
The commands we have now are:
I tested this via:
After this step the database exists and we can validate that the phase 1 root has been inserted in the database:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll just apply my suggestion, check CI, and then merge
Signed-off-by: Lúcás Meier <cronokirby@gmail.com>
Closes #3156
Note that I have intentionally not done the transition from the provided phase 1 to phase 2, which will be done in #3158 which I'll pick up after this one.