Summonerd: transition and export #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Failure
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Failure
cronokirby
force-pushed
the
summonerd-transition-and-export
branch
from
eb22d74 to
218aa68
Compare
cronokirby
force-pushed
the
summonerd-transition-and-export
branch
from
77f125e to
8827a7d
Compare
cronokirby
force-pushed
the
summonerd-transition-and-export
branch
from
8827a7d to
872b716
Compare
There was a problem hiding this comment.
Look at this today and the diff itself LGTM, however for me the transition is not completing (ran for over an hour or so before stopping), I haven't debugged further yet but my suspicion is that it's to do with somewhere we're using the checked methods on CanonicalDeserialize
|
|
||
| let phase1_crs = match storage.phase1_current_crs().await? { | ||
| Some(x) => x, | ||
| None => anyhow::bail!("Please run phase1 before this command 8^)"), |
There was a problem hiding this comment.
by phase1 here, we currently mean loading the generated phase 1 root using init, and by phase2 we mean running start (after transition) ✅
More useful for error handling: this is because you can then react explicitly to a missing CRS, and warn to run other commands first.
cronokirby
force-pushed
the
summonerd-transition-and-export
branch
from
872b716 to
ebc8234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3158.
Closes #3159.
Closes #3160.
We could do some integration testing of things before merging as well.