Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve summonerd performance through parallelism #3208

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Conversation

cronokirby
Copy link
Contributor

@cronokirby cronokirby commented Oct 18, 2023

Closes #3202, although I'm not quite sure we're exploiting everything we can.

In particular, the way you enable parallelism in arkworks through spooky action at a distance always makes me unsure if I've done things correctly. Would appreciate a review of that specifically.

(Also, I refactored some of the code so this PR ends up being a net decrease in loc 8^))

@cronokirby cronokirby temporarily deployed to smoke-test October 18, 2023 17:38 — with GitHub Actions Inactive
@cronokirby cronokirby temporarily deployed to smoke-test October 18, 2023 21:14 — with GitHub Actions Inactive
@cronokirby cronokirby temporarily deployed to smoke-test October 19, 2023 17:37 — with GitHub Actions Inactive
@cronokirby cronokirby temporarily deployed to smoke-test October 19, 2023 18:47 — with GitHub Actions Inactive
@cronokirby cronokirby temporarily deployed to smoke-test October 19, 2023 19:18 — with GitHub Actions Inactive
@cronokirby cronokirby marked this pull request as ready for review October 19, 2023 19:19
Probably the more useful benchmarks to run
@cronokirby cronokirby temporarily deployed to smoke-test October 20, 2023 07:10 — with GitHub Actions Inactive
Copy link
Member

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@redshiftzero redshiftzero merged commit 1d12603 into main Oct 20, 2023
8 checks passed
@redshiftzero redshiftzero deleted the summonerd-go-brrr branch October 20, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summonerd: Use parallelism to improve contribution speed
2 participants