Improve summonerd performance through parallelism #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
force-pushed
the
summonerd-go-brrr
branch
from
ce89f23 to
4699a56
Compare
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Failure
cronokirby
force-pushed
the
summonerd-go-brrr
branch
from
2f2dece to
f4add06
Compare
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Failure
Probably the more useful benchmarks to run
cronokirby
force-pushed
the
summonerd-go-brrr
branch
from
f4add06 to
ad2ece0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3202, although I'm not quite sure we're exploiting everything we can.
In particular, the way you enable parallelism in arkworks through spooky action at a distance always makes me unsure if I've done things correctly. Would appreciate a review of that specifically.
(Also, I refactored some of the code so this PR ends up being a net decrease in loc 8^))