Minor ceremony UX improvements #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
e2e summonerd test passed on this branch: https://github.com/penumbra-zone/penumbra/actions/runs/6591837548/job/17911259719 |
|
Refs #3218 |
hdevalence
changed the title
Now we correctly bubble these upstream and crash the entire server. This is what we want, because these crashes are unexpected and indicative of some actual issue.
These are treated as failures to contribute, rather than unexpected events requiring the server to crash.
|
This PR closes most of the items in #3218 at this point; the remaining one is a sort of vague item on profiling to find potential optimization points we might have missed in summonerd. |
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made during pairing.