Simplify state management in summonerd #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(necessary with recent modifications)
|
https://github.com/penumbra-zone/penumbra/actions/runs/6635035943 the full summoning smoke test passed successfully as well, but a careful review is still warranted imo |
hdevalence
reviewed
Oct 25, 2023
Comment on lines
+53
to
56
| self.storage.strike(&address).await?; | ||
| Ok(()) | ||
| } | ||
| Ok(Err(e)) => Err(e), |
There was a problem hiding this comment.
Why do we want to bubble up an error here if contribute_inner fails? If a participant does something bad (e.g., submitting something that fails validation), won't this still crash the server?
hdevalence
reviewed
Oct 25, 2023
| use tonic::{Status, Streaming}; | ||
|
|
||
| use crate::phase::Phase; | ||
|
|
||
| pub struct Participant { | ||
| address: Address, | ||
| rx: Streaming<pb::ParticipateRequest>, | ||
| rx: Mutex<Streaming<pb::ParticipateRequest>>, |
There was a problem hiding this comment.
I don't think we should be using a Mutex here, why are we sharing access to the participant's messages?
|
The comments above are largely stylistic; I'm not sure that the new code structure is optimal, but I think it may be good enough for the purposes of our ceremony, so we could merge this and move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3221