pcli: add config file generated by pcli init
#3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
force-pushed
the
pcli-pd-config
branch
from
93a6863 to
55ddd78
Compare
This change has a few different goals: 1. It simplifies `pcli`'s command-line interface, by moving configuration out of the CLI arguments and into a config file. The top-level `--home` parameter now controls everything, since it determines where `pcli` will load configuration data from. 2. It opens the door to having more custody backends in the future (like hardware wallets or threshold custody) by making the custody backend configurable in the config file. 3. It acts as a forcing function for testnet users to migrate to BIP44-derived addresses. `pcli` won't work without the config file, and the config file is generated from `pcli init`, which only accepts a seed phrase (and uses BIP44 derivation by default). So users need to re-insert their seed phrases; if they've lost access to the seed phrase, now is a much better time to find out than mainnet. Point (3) is in contrast with previous changes, where we've auto-migrated data. Now we force re-importing it, to ensure that that flow works.
hdevalence
force-pushed
the
pcli-pd-config
branch
from
55ddd78 to
b12557c
Compare
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
hdevalence
force-pushed
the
pcli-pd-config
branch
from
a66d726 to
41b25c0
Compare
conorsch
added a commit
that referenced
this pull request
Oct 31, 2023
Follow up to the new `pcli init` logic [0], adding a more informative error message, in case folks forget to rotate their address format, as required by Rhea 63. [0] #3239
hdevalence
pushed a commit
that referenced
this pull request
Oct 31, 2023
Follow up to the new `pcli init` logic [0], adding a more informative error message, in case folks forget to rotate their address format, as required by Rhea 63. [0] #3239
conorsch
added a commit
that referenced
this pull request
Nov 14, 2023
Since we moved to new pcli config file in #3239, we don't use the archives anymore. If a machine doesn't have archive dirs, then pcli will throw an error, which is bad. Stop looking for archive dirs. Similar, we shouldn't look for a custody.json file, we should look for the new config.toml file. Closes #3321.
hdevalence
pushed a commit
that referenced
this pull request
Nov 14, 2023
Since we moved to new pcli config file in #3239, we don't use the archives anymore. If a machine doesn't have archive dirs, then pcli will throw an error, which is bad. Stop looking for archive dirs. Similar, we shouldn't look for a custody.json file, we should look for the new config.toml file. Closes #3321.
conorsch
added a commit
that referenced
this pull request
Nov 16, 2023
Since we moved to new pcli config file in #3239, we don't use the archives anymore. If a machine doesn't have archive dirs, then pcli will throw an error, which is bad. Stop looking for archive dirs. Similar, we shouldn't look for a custody.json file, we should look for the new config.toml file. Closes #3321. (cherry picked from commit f839582)
conorsch
added a commit
that referenced
this pull request
Nov 16, 2023
Since we moved to new pcli config file in #3239, we don't use the archives anymore. If a machine doesn't have archive dirs, then pcli will throw an error, which is bad. Stop looking for archive dirs. Similar, we shouldn't look for a custody.json file, we should look for the new config.toml file. Closes #3321. (cherry picked from commit f839582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has a few different goals:
It simplifies
pcli's command-line interface, by moving configuration out of the CLI arguments and into a config file. The top-level--homeparameter now controls everything, since it determines wherepcliwill load configuration data from.It opens the door to having more custody backends in the future (like hardware wallets or threshold custody) by making the custody backend configurable in the config file.
It acts as a forcing function for testnet users to migrate to BIP44-derived addresses.
pcliwon't work without the config file, and the config file is generated frompcli init, which only accepts a seed phrase (and uses BIP44 derivation by default). So users need to re-insert their seed phrases; if they've lost access to the seed phrase, now is a much better time to find out than mainnet.Point (3) is in contrast with previous changes, where we've auto-migrated data. Now we force re-importing it, to ensure that that flow works.