pd: add --enable-expensive-rpc flag
#3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erwanor mind if I tack on the necessary deployment changes to this PR, so that we can use this on preview once it's merged? I can also follow up in a separate PR if you'd prefer. |
|
Not at all, thanks actually |
|
Not to bikeshed, but I'm wondering if this could be --enable-expensive-rpc or something similar, so that we could just have one flag and if we add some other similar RPC later we could have it all grouped into one setting. |
erwanor
changed the title
--simulate-trade-service flag--enable-expensive-rpc flag
Here we unconditionally enable serving expensive gRPC services via pd for the fullnodes. We could make this option configurable in the deployment logic, but our use case is that we want the expensive options to be available to the dev team, so just forcing them all on. Notably we don't expose the RPC services for the genesis validators, and we're not enabling the flag on pd for the gen vals, so we'll monitor performance on the load-balanced fullnode endpoints and adjust if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--simulate-trade-serviceflag topdthat activates the DEX trade simulation service, which allow users to sendSimulateTradeRPCs. The service is disabled by default, because it can be onerous to run it against a rich orderbook, and therefore is a potential DoS vector.