custody: fill in scope of CustodyService #3331
Conversation
This fills in missing methods that allow the CustodyService to be the interface to a device like a hardware wallet, or to allow websites to request confirmation for displayed addresses. Co-Authored-By: Lucas Meier <lucas@cronokirby.com> Co-Authored-By: Jen Helsby <jen@penumbralabs.xyz>
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
| // Requests the full viewing key from the custodian. | ||
| // | ||
| // Custody backends should decide whether to honor this request, and how to | ||
| // control access to it. | ||
| rpc ExportFullViewingKey(ExportFullViewingKeyRequest) returns (ExportFullViewingKeyResponse); |
There was a problem hiding this comment.
@grod220 The web extension should implement this method by erroring out.
| // Displays an address to a user for confirmation. | ||
| // | ||
| // Custody backends with user interaction should present the address to the | ||
| // user and wait for explicit confirmation before returning. | ||
| // | ||
| // Non-interactive custody backends may return immediately. | ||
| rpc ConfirmAddress(ConfirmAddressRequest) returns (ConfirmAddressResponse); |
There was a problem hiding this comment.
@grod220 The web extension should implement this method by creating an extension popup. The point of this is to allow web content to steer users to copy an address they'll send to someone else from trusted UI. Realistically, though, we won't be able to ensure that users don't ever copy an address from the web content, but we can give an option for trusted display.
There was a problem hiding this comment.
So this will trigger a popup for a user to copy any of their addresses? Sort of like this?
There was a problem hiding this comment.
Yeah, the idea is to provide a way to confirm an address on a trusted display path controlled by the custodian. For a Ledger this is viewing the address on screen, for the web extension this would be some kind of popup trigger. I don't think it's a super high priority in the web extension but something that would be nice to have eventually
This fills in missing methods that allow the CustodyService to be the interface to a device like a hardware wallet, or to allow websites to request confirmation for displayed addresses.
Result of pairing with @redshiftzero and @cronokirby .