refactor: bundled-proving-keys #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalDerei
changed the title
TalDerei
changed the title
hdevalence
reviewed
Nov 15, 2023
Nice!!!! |
TalDerei
changed the title
TalDerei
had a problem deploying
to
smoke-test
GitHub Actions
Failure
TalDerei
had a problem deploying
to
smoke-test
GitHub Actions
Failure
TalDerei
had a problem deploying
to
smoke-test
GitHub Actions
Failure
TalDerei
had a problem deploying
to
smoke-test
GitHub Actions
Failure
hdevalence
reviewed
Nov 17, 2023
hdevalence
reviewed
Nov 17, 2023
hdevalence
reviewed
Nov 17, 2023
This ensures that proving keys are always checked against hardcoded hashes, regardless of source.
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
@TalDerei This looks great! I added another commit that merges the check-ID behavior from the existing |
This was referenced Nov 17, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #2712. A new
LazyProvingKeytype is introduced to represent the proving keys. The limitation with the formerLazytype was thatLazy::new()expects a closure. This ultimately creates a tight coupling with the declaration of a static lazy variable and its initialization. TheLazyProvingKeyenables this separation based on the conditionalbundled-proving-keysfeature.This will further reduce the wasm binary size to only include the verification keys, originally from ~90MB to a few MB.