-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try restoring SQLite pragmas #3338
Conversation
Closes #3329 This restores configurations we had prior to migrating to rusqlite.
On my machine, this branch is nearly 50x faster when syncing the 437736 blocks of Testnet 63 Rhea:
I had to reset/re-sync several times before I was able to generate an error. |
The errors occurred fairly reliably on db initialization, but not on sync resumption after init:
Adding a bunch of tracing statements showed that the errors were occurring specifically during the
@hdevalence if you agree these changes are solid, I'll squash, merge, and cherry-pick onto a point release. |
c53a6d4
to
ec14f7a
Compare
Seems good! I don't have particular insight into the sqlite internals but the explanation seems solid |
Ran this independently; can confirm no errors on sync, and a speedup on Linux. |
(cherry picked from commit 5f51840)
(cherry picked from commit 5f51840)
Closes #3329
This restores configurations we had prior to migrating to rusqlite.
Even on MacOS this results in speed improvements syncing the chain with a newly generated wallet:
vs
Note however that now there are errors. So this isn't a complete solution. Nothing will conflict with this PR, so there's no rush to merge it.